-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode 10 & Swift 4.2 support #73
Conversation
a37c91b
to
6d98524
Compare
👍 very cool!. |
Will merge and release later today. |
@@ -1,4 +1,4 @@ | |||
// swift-tools-version:4.1 | |||
// swift-tools-version:4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not meant to be 4.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No - It supports both Swift 4 and Swift 4.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies. I must be doing something wrong when pulling in 0.9.0 binary via Carthage. Throws Incompatible Swift version - framework was built with 4.0.3 ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhm that shouldn't be the case, I built it locally on my mac which has Swift 4.2. Keep trying and if you don't figure this out by weekend I'll try to help out with local testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll dig around, and will post any followups on the issue instead, where it is more appropriate: #68
Supersedes #72.
Fixes #68 , #69.