Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 10 & Swift 4.2 support #73

Merged
merged 4 commits into from
Sep 23, 2018
Merged

Xcode 10 & Swift 4.2 support #73

merged 4 commits into from
Sep 23, 2018

Conversation

freak4pc
Copy link
Member

Supersedes #72.
Fixes #68 , #69.

@freak4pc freak4pc force-pushed the swift4.2 branch 3 times, most recently from a37c91b to 6d98524 Compare September 21, 2018 17:13
@vaderdan
Copy link

👍 very cool!.
Will you place binary in
https://github.com/RxSwiftCommunity/RxKeyboard/blob/master/RxKeyboard.json
just is it here the place to do it or not -> just question :)

@freak4pc
Copy link
Member Author

Will merge and release later today.

@freak4pc freak4pc merged commit c92e75b into master Sep 23, 2018
@freak4pc freak4pc deleted the swift4.2 branch September 23, 2018 10:30
@@ -1,4 +1,4 @@
// swift-tools-version:4.1
// swift-tools-version:4.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not meant to be 4.2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - It supports both Swift 4 and Swift 4.2.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies. I must be doing something wrong when pulling in 0.9.0 binary via Carthage. Throws Incompatible Swift version - framework was built with 4.0.3 ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm that shouldn't be the case, I built it locally on my mac which has Swift 4.2. Keep trying and if you don't figure this out by weekend I'll try to help out with local testing.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll dig around, and will post any followups on the issue instead, where it is more appropriate: #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants